Skip to content
Snippets Groups Projects

113 grpc lib

Merged 113 grpc lib
113_grpc_lib into master
Merged Richer Maximilien requested to merge 113_grpc_lib into master

Implement gRPC primitives

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loïck Bonniot
  • Loïck Bonniot
  • Loïck Bonniot
    Loïck Bonniot @lbonniot ·
    Owner

    Nice one :yellow_heart:

    Some points:

    • It could be interesting to handle error differently, for example returning errors instead of fatal crash. Could be done in a later upgrade.
    • It might be useful to have an example of this; one for the client and one for the server. Feel free to use the test framework or not in this case :lollipop:
    • Don't forget to check this code with gofmt
  • Richer Maximilien Added 1 commit:

    Added 1 commit:

  • Richer Maximilien
    Richer Maximilien @mricher ·
    Author Maintainer

    I've improved the doc, following godoc syntax. Testing is messy, and so is an example, because of the large amount of dependent code (protobuf message and x509 stuff). There is a working example in the note repository, so I'm not trashing the testing/example stuff but I'll take care of it later, maybe next week.

    Edited by Richer Maximilien
  • Loïck Bonniot mentioned in commit 7f0be09a

    mentioned in commit 7f0be09a

  • Loïck Bonniot Status changed to merged

    Status changed to merged

    • Please register or sign in to reply